Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added footer in all the components category page #1458

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

pragna7
Copy link
Contributor

@pragna7 pragna7 commented Jan 15, 2025

Fixes Issue🛠️

Closes #638

Description👨‍💻

Whenever someone clicks on any of the component pages, there's no footer on the components page, only header is there.
To maintain uniformity and professionalism, a footer is added on all the pages.

Type of Change📄

  • New feature (non-breaking change which adds functionality)
  • Style (non-breaking change which improves website style or formatting)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

image

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit ba0f2ee
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/678a26b12834a6000807d386
😎 Deploy Preview https://deploy-preview-1458--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pragna7, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@pragna7
Copy link
Contributor Author

pragna7 commented Jan 15, 2025

@Rakesh9100 I hope you're doing well. As today is the final submission date for KWOC, could you please review and merge my PR at your earliest convenience? Your support is greatly appreciated.

@Rakesh9100
Copy link
Owner

Please design a short, simple, and aesthetically pleasing footer for these pages. Ensure it spans the full width and extends all the way to the bottom. Avoid simply copying and pasting the same footer @pragna7

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jan 15, 2025
@pragna7
Copy link
Contributor Author

pragna7 commented Jan 15, 2025

@Rakesh9100 okay ,Thanks for the review

@Rakesh9100
Copy link
Owner

If you are working, then make the new commit in this same PR, don't close and create a new one @pragna7

@Rakesh9100 Rakesh9100 changed the title Adding Footer to all files Added footer in all the components category page Jan 17, 2025
@Rakesh9100 Rakesh9100 merged commit 963ff20 into Rakesh9100:main Jan 17, 2025
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @pragna7

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion Intermediate Intermediate level task Medium Moderate level implementation task and removed question 🤔 Further information is requested Intermediate Intermediate level task labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Medium Moderate level implementation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add footer in all the components category page
2 participants