Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate new strings to EL (Greek) #1618

Closed
wants to merge 3 commits into from
Closed

Translate new strings to EL (Greek) #1618

wants to merge 3 commits into from

Conversation

Devnol
Copy link
Contributor

@Devnol Devnol commented Mar 12, 2023

  • Please check if the PR fulfills these requirements
  • [] The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Translate new strings to EL

Sorry for taking so long, I had literally forgotten about it until now.

@Devnol
Copy link
Contributor Author

Devnol commented Mar 12, 2023

These are the strings that were immediately obvious, if something else has changed please do let me know so I can add it.

Copy link
Collaborator

@discip discip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Devnol
Unfortunately you did use an old translation file, please update your fork first.

Currently the dev branch is the default, instead of the master branch.

So you would need to adapt this file translation_EL.json.

@Devnol
Copy link
Contributor Author

Devnol commented Mar 13, 2023

whoop, sorry. Will do. Also, I'm sorry to bother you about this but could you please take a look at this? I could really use some help.

@discip
Copy link
Collaborator

discip commented Mar 13, 2023

You do not need to be sorry at all! 😊

It's fine!

@Devnol Devnol closed this by deleting the head repository Mar 13, 2023
@Devnol
Copy link
Contributor Author

Devnol commented Mar 13, 2023

for some reason I didn't have a dev branch on my fork and I couldn't be bothered to find how to do that now so I think the easiest option was to just yeet it and start over, see pr #1623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants