Skip to content

Commit

Permalink
restore 'maxgap' special meaning when 'type' is set to "start" or "end"
Browse files Browse the repository at this point in the history
  • Loading branch information
[email protected] committed Jun 8, 2015
1 parent 4aac21e commit 0fbdf47
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ Description: The ability to efficiently represent and manipulate genomic
intervals. Specialized containers for representing and manipulating
short alignments against a reference genome are defined in the
GenomicAlignments package.
Version: 1.21.14
Version: 1.21.15
Author: P. Aboyoun, H. Pages and M. Lawrence
Maintainer: Bioconductor Package Maintainer <[email protected]>
biocViews: Genetics, Infrastructure, Sequencing, Annotation, Coverage,
GenomeAnnotation
Depends: R (>= 2.10), methods, BiocGenerics (>= 0.11.3), S4Vectors (>= 0.7.3),
IRanges (>= 2.3.9), GenomeInfoDb (>= 1.1.20)
IRanges (>= 2.3.11), GenomeInfoDb (>= 1.1.20)
Imports: utils, stats, XVector
LinkingTo: S4Vectors, IRanges
Suggests: Biobase, AnnotationDbi (>= 1.21.1), annotate, Biostrings (>= 2.25.3),
Expand Down
8 changes: 2 additions & 6 deletions R/findOverlaps-methods.R
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,8 @@ findOverlaps_GenomicRanges <- function(query, subject,
algorithm=c("nclist", "intervaltree"),
ignore.strand=FALSE)
{
min.score <- IRanges:::min_overlap_score(maxgap, minoverlap)
type <- match.arg(type)
if (!identical(maxgap, 0L) && type != "any")
warning(IRanges:::maxgap_special_meaning_msg)
min.score <- IRanges:::min_overlap_score(maxgap, minoverlap, type)
select <- match.arg(select)
algorithm <- match.arg(algorithm)
if (algorithm != "nclist")
Expand Down Expand Up @@ -586,10 +584,8 @@ countOverlaps_GenomicRanges <- function(query, subject,
algorithm=c("nclist", "intervaltree"),
ignore.strand=FALSE)
{
min.score <- IRanges:::min_overlap_score(maxgap, minoverlap)
type <- match.arg(type)
if (!identical(maxgap, 0L) && type != "any")
warning(IRanges:::maxgap_special_meaning_msg)
min.score <- IRanges:::min_overlap_score(maxgap, minoverlap, type)
algorithm <- match.arg(algorithm)
if (algorithm != "nclist")
warning("'algorithm' is ignored when 'query' or 'subject' ",
Expand Down

0 comments on commit 0fbdf47

Please sign in to comment.