Skip to content

Commit

Permalink
BUILD, DOC: fix 14518, add release note
Browse files Browse the repository at this point in the history
  • Loading branch information
mattip committed Sep 22, 2019
1 parent 5ab256e commit aa0f7f7
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
18 changes: 18 additions & 0 deletions doc/release/upcoming_changes/14518.change.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
Add options to quiet build configuration and build with ``-Werror``
-------------------------------------------------------------------
Added two new configuration options. During the ``build_src`` subcommand, as
part of configuring NumPy, the files ``_numpyconfig.h`` and ``config.h`` are
created by probing support for various runtime functions and routines.
Previously, the very verbose compiler output during this stage clouded more
important information. By default the output is silenced. Running ``runtests.py
--debug-configure`` will add ``-v`` to the ``build_src`` subcommand, which
will restore the previous behaviour.

Adding ``CFLAGS=-Werror`` to turn warnings into errors would trigger errors
during the configuration. Now ``runtests.py --warn-error`` will add
``--warn-error`` to the ``build`` subcommand, which will percolate to the
``build_ext`` and ``build_lib`` subcommands. This will add the compiler flag
to those stages and turn compiler warnings into errors while actually building
NumPy itself, avoiding the ``build_src`` subcommand compiler calls.

(`gh-14527 <https://github.com/numpy/numpy/pull/14527>`__)
2 changes: 1 addition & 1 deletion numpy/distutils/command/build_src.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def initialize_options(self):
self.swig_opts = None
self.swig_cpp = None
self.swig = None
self.verbose = False
self.verbose = None

def finalize_options(self):
self.set_undefined_options('build',
Expand Down

0 comments on commit aa0f7f7

Please sign in to comment.