Skip to content

Commit

Permalink
fix dark mode colours (#1182)
Browse files Browse the repository at this point in the history
  • Loading branch information
conorriches authored Jan 30, 2025
1 parent a339606 commit e072598
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Allow `instructions` attribute to override instructions attached to the project (#1169)
- Instructions tabs for edit and viewing (#1167)
- Add remove instructions button modal (#1176)
- Dark mode colours (#1182)

### Changed

Expand Down
12 changes: 9 additions & 3 deletions src/assets/stylesheets/Instructions.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
margin: 0;
}

a {
color: var(--editor-color-theme-secondary);
}

strong {
font-weight: $font-weight-bold;
}
Expand Down Expand Up @@ -263,7 +267,7 @@
}

.project-instructions__empty {
background-color: $rpf-teal-100;
background-color: var(--editor-color-layer-1);
border-radius: $space-0-5;
display: flex;
flex-direction: column;
Expand Down Expand Up @@ -292,11 +296,11 @@
}

.react-tabs__tab {
background: var(--rpf-off-white);
background: var(--editor-color-tab-background);
padding-inline: var(--space-1-5);

&--selected {
background: var(--rpf-white);
background: var(--editor-color-layer-3);
}
}

Expand All @@ -309,6 +313,8 @@
textarea {
@include typography.style-1();

background: var(--editor-color-layer-3);
color: var(--editor-color-text);
border: none;
block-size: 100%;
overflow-block: scroll;
Expand Down
2 changes: 2 additions & 0 deletions src/assets/stylesheets/InternalStyles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ button:focus-visible {
--editor-color-theme-tertiary: #{$rpf-teal-100};
--editor-color-text: #{$rpf-text-primary};
--editor-color-text-secondary: #{$rpf-text-secondary};
--editor-color-tab-background: #{$rpf-off-white};
}

.--dark {
Expand All @@ -116,6 +117,7 @@ button:focus-visible {
--editor-color-text: #{$rpf-white};
--editor-color-text-secondary: #{$rpf-text-secondary-darkmode};
--rpf-button-secondary-text-color: #{$rpf-white};
--editor-color-tab-background: #{$rpf-grey-700};

.rpf-button--secondary {
border-color: $rpf-navy-800;}
Expand Down

0 comments on commit e072598

Please sign in to comment.