Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove instructions button modal #1176

Merged
merged 28 commits into from
Jan 30, 2025

Conversation

jamiebenstead
Copy link
Contributor

Work for this ticket.

Copy link
Member

@conorriches conorriches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, great small refactors in here too.

I'm happy to approve, but I think cypress may need fixing first

@jamiebenstead jamiebenstead temporarily deployed to previews/1176/merge January 29, 2025 14:23 — with GitHub Actions Inactive
Base automatically changed from feat/editable-instructions to main January 30, 2025 10:55
@jamiebenstead jamiebenstead temporarily deployed to previews/1176/merge January 30, 2025 12:35 — with GitHub Actions Inactive
@jamiebenstead jamiebenstead temporarily deployed to previews/1176/merge January 30, 2025 12:46 — with GitHub Actions Inactive
src/utils/i18n.js Outdated Show resolved Hide resolved
@jamiebenstead jamiebenstead temporarily deployed to previews/1176/merge January 30, 2025 15:35 — with GitHub Actions Inactive
@jamiebenstead jamiebenstead merged commit a339606 into main Jan 30, 2025
8 checks passed
@jamiebenstead jamiebenstead deleted the add-remove-instructions-button-modal branch January 30, 2025 15:54
@danhalson danhalson mentioned this pull request Feb 6, 2025
danhalson added a commit that referenced this pull request Feb 6, 2025
## What's Changed
* Support output tabs in pyodide by @loiswells97 in
#1157
* Downloading the instructions by @loiswells97 in
#1160
* Hack open function to write files in main thread by @loiswells97 in
#1146
* Try pinning previous ubuntu version to avoid cloudflare issue by
@danhalson in
#1178
* Integration: Save / Login functionality not as expected by
@create-issue-branch in
#1162
* HTML audio video support by @loiswells97 in
#1179
* Feat/editable instructions by @loiswells97 in
#1166
* Add remove instructions button modal by @jamiebenstead in
#1176
* fix dark mode colours by @conorriches in
#1182
* Copy change: Project steps to Project instructions by @loiswells97 in
#1183
* Fixing padding for first line of code block by @loiswells97 in
#1184
* Fix contrast on dark mode instructions code block by @loiswells97 in
#1187
* Markdown changes by @jamiebenstead in
#1188
* Remove line from demoInstructions by @jamiebenstead in
#1189
* Instructions syntax highlighting for CEfE by @loiswells97 in
#1190
* Fixing instructions state when set to an empty string by @loiswells97
in #1191
* Identify caching issue for editor-ui by @create-issue-branch in
#1186

## New Contributors
* @jamiebenstead made their first contribution in
#1176

**Full Changelog**:
v0.28.14...v0.29.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants