Skip to content

Commit

Permalink
fix: remove hardcoded HOSTNAME in Docker
Browse files Browse the repository at this point in the history
Instead of hardcoding it in supervisord.conf, we simply set it to an
empty value in the Dockerfile. This prevents docker from setting it's
own value while also allowing the user to override it.

In next JS an empty HOSTNAME is equivalent to not setting it at all.
  • Loading branch information
dumbasPL authored and Ravinou committed Dec 8, 2024
1 parent 72d3fec commit b0fae4f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ ARG UID
ARG GID

ENV NODE_ENV production
ENV HOSTNAME=

RUN echo 'deb http://deb.debian.org/debian bookworm-backports main' >> /etc/apt/sources.list
RUN apt-get update && apt-get install -y \
Expand Down
1 change: 0 additions & 1 deletion docker/supervisord.conf
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ stdout_logfile_backups=5
redirect_stderr=true

[program:borgwarehouse]
environment=HOSTNAME=0.0.0.0
command=/usr/local/bin/node server.js
stdout_logfile=/home/borgwarehouse/tmp/borgwarehouse.log
stdout_logfile_maxbytes=10MB
Expand Down

0 comments on commit b0fae4f

Please sign in to comment.