feat: Add Sprint #80
Open
feat: Add Sprint #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome. Do you know if something can be done for pots as well? With that said, this project doesn't seem to be maintained anymore :( Edit: For pots, looks like the action ID changes every patch even for the same item. |
|
Hey @HaySome22, thanks! I actually already added pots to my fork, was just waiting to get attention on this PR before submitting a new one. My fork is also hosted so feel free to use it instead. Let me know if it works for you
|
|
Nice, your fork works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all, thank you for this amazing plugin. I love it, use it all the time and find it extremely useful!
While reviewing some VODs I noticed that Sprint was not showing. I noticed it's because it is not categorized as a combat action so I added a little exception just for it. Although it is true that's not specifically for combat, certain raid mechanic benefit a lot from its usage and given that this is mostly an educational tool I feel it would be helpful to have it displayed.
Let me know if you're okay with this change or if you'd like a different approach.
Thanks again!
https://xivapi.com/Action/3?columns=Icon,Name,ActionCategoryTargetID
https://xivapi.com/i/000000/000405.png
https://xivapi.com/i/000000/000104.png