Changed from noir to Compojure and lib-noir #45
Conversation
|
Hey there! Thanks for the pull request. I'm a bit busy at work at the moment, but I'm going to go through and comment on the changes asap. I see a few small issues, but otherwise great work! Thanks for taking the time to do this. It was certainly a lot of old cruft. |
|
|
||
| (server/add-middleware wrap-file (System/getProperty "user.dir")) | ||
| (server/load-views "src/tryclojure/views") | ||
| (def app-routes |
There was a problem hiding this comment.
The indentation appears to be off here. Each item of this vector should be indented the same.
…on in the app-routes function (lined up the vectors) and moved ] characters so they are not on their own lines
…to use spaces so it should line up correctly now
…to use spaces so it should line up correctly now
… these are essentially partials (except for root-html which is the main document)
|
Thanks for the feedback, glad I am maybe able to help. I have adjusted the line indentations in the app-routes function and switched to Long for the port number (incidentally, that line of code is taken from Heroku's clojure getting started). Finally, I have slurped up the trailing ]s where I saw them so they no longer dangle on there own lines. Also, I noticed that the HTML was a bit wrong due to the fact I was using html5 for partial page html - I have corrected that too (had a bit of a git nightmare, hence multiple commits, sorry about that). |
|
You're the best kind of person. I cleaned up the commits a bit and dumped them into master. I'll deploy this asap. Thanks for all the fish! |
I came to your web site from http://clojure.org using IE 10 and I was instantly presented with issue #35 (i.e no CSS styling applied) and I thought, maybe I can fix that. After a bit of research and reading issue #38 I figured the fault lay somewhere in the HTTP infrastructure you're using so I went on over to noir's page (http://webnoir.org) with the intention of fixing it there and noticed that it is deprecated in favor of lib-noir and compojure.
So, I have converted your project to lib-noir and compojure, and this is what this pull request is (it is my first, I do not really know the etiquette, sorry).
After doing that I found that issue 35 is fixed (well, I only have IE 10 and it talks about IE 9 but given the symptom was the same, I am pretty sure it will be fixed along with issue 38 too I suppose, for the same reason).
Finally, I noticed that you are hosting using Heroku so to make sure I didn't break that I created a Heroku app with my changes in which you can look at here: http://frozen-gorge-6602.herokuapp.com/. I have given it a bit of a bash and it seems to be fine (I am just using a free account so may be slow).