Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release JSFX Library to make JSFX plugins look nicer (and easier to program) v0.Alpha.1 #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhilRangerQuebec
Copy link

No description provided.

@cfillion
Copy link
Member

cfillion commented Feb 19, 2025

  • Is the intent of this package releasing the demo script of the library, or the library itself? It's currently the former but the display name doesn't reflect that.

    (Since each JSFX is expected to be self-contained, just demo package seems the best way to release. Users of the library would ship their own copy rather than link to this one.)

  • The URL at line 16 is broken.

  • The library should use .jsfx-inc extension to not be shown in the FX browser.

  • Is "Test Phil Ranger Library version Alpha.jsfx" the permanent name? The package filename identifies it forever and cannot be changed later (eg. when it's no longer "version alpha").

  • The import path should include the relative subdirectory.

@PhilRangerQuebec
Copy link
Author

PhilRangerQuebec commented Feb 19, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants