Resolve ambiguity in the prod method for ProductOf #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nimrais
reviewed
Jul 4, 2024
Comment on lines
+334
to
+335
| SomeArbitraryDistribution(), | ||
| ProductOf(SomeArbitraryDistribution(), SomeArbitraryDistribution()), |
There was a problem hiding this comment.
If I am not wrong PR tries to fix this as well?
julia> prod(GenericProd(), ProductOf(Normal(0, 1), Normal(0, 1)), ProductOf(Normal(0, 1), Normal(0, 1)))
ERROR: MethodError: prod(::GenericProd, ::ProductOf{Normal{Float64}, Normal{Float64}}, ::ProductOf{Normal{Float64}, Normal{Float64}}) is ambiguous.
Candidates:
prod(::GenericProd, left::ProductOf{L, R}, right::T) where {L, R, T}
@ BayesBase ~/.julia/packages/BayesBase/MnjV6/src/prod.jl:252
prod(::GenericProd, left::T, right::ProductOf{L, R}) where {L, R, T}
@ BayesBase ~/.julia/packages/BayesBase/MnjV6/src/prod.jl:285
Possible fix, define
prod(::GenericProd, ::T, ::T) where {L, R, L, R, T<:ProductOf{L, R}, T<:ProductOf{L, R}}
Stacktrace:
[1] top-level scope
@ REPL[34]:1
There was a problem hiding this comment.
Because it still fails on this branch for me.
There was a problem hiding this comment.
this PR in particular is not aimed to solve this particular case, I think this one can be a separate issue, as it is can be quite complex in general
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue with method ambiguity with certain parameters configuration for the
prodfunction.