-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed migration script at applications/batch endpoint that added createdAt and status fields to applicants collection #2096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add the reference of org PR
@yeshavyas27 #2094 is still open, then what what do you mean by "Closes" |
@yeshavyas27 In desc it's says developer tested, can you add proof as well please |
@iamitprakash I have added a screenshot under 'Test Coverage'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yeshavyas27 the test coverage screenshot that you shared is not up to the mark. can you please update a new one, You can compare your screenshot with others for reference
if this PR is in place #2092 do we really need this PR. CC- @vinit717 |
@yeshavyas27 I will wait for @vinit717 to approve first as he has more context on this |
Make two PR's one for removing /batch route and it's code and another for removing /batch/update and it;s code and test |
2706353
to
c29bc92
Compare
…plicants collection
633d803
to
9003559
Compare
…At-status-fields-to-applicants-collection
Date:
22 August, 2024
Developer Name: @yeshavyas27
Issue Ticket Number
Description
This PR removes the applications/batch endpoint and its related code that added createdAt and status fields to the applicants' collection.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Test Coverage
Unit Tests:
![image](https://private-user-images.githubusercontent.com/103744693/361534482-d876fd15-0662-4da7-a5db-c616f6fd770b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODI2NTcsIm5iZiI6MTczOTI4MjM1NywicGF0aCI6Ii8xMDM3NDQ2OTMvMzYxNTM0NDgyLWQ4NzZmZDE1LTA2NjItNGRhNy1hNWRiLWM2MTZmNmZkNzcwYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxMzU5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMjFhYzE3YmU1ZTI4NDhhMGRmY2QwZGU5YjMyNDUyZmZkMDQ4NjYxMDBmY2IwNTgxZjUxZmExNTIxNDYyMzNhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.zisW616zq0qEsqDLFbdQhDRx9EZKm1xOfCu2p2uBEeY)
Integration Tests:
![image](https://private-user-images.githubusercontent.com/103744693/361534039-5725bcbd-121b-47ca-a7a2-d77a0ed5f8df.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODI2NTcsIm5iZiI6MTczOTI4MjM1NywicGF0aCI6Ii8xMDM3NDQ2OTMvMzYxNTM0MDM5LTU3MjViY2JkLTEyMWItNDdjYS1hN2EyLWQ3N2EwZWQ1ZjhkZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxMzU5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYmI0ODhiNTdiOGUxNjJjMDVkMTVhNzFkNzBlOTAyMWMyOTk0YTRmMGI2YTFmNWI1YTgxOTc4OGMzMTRmNWE3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.-Vj8y3KX-mY2L3iq8Ko0mL6yvSyRBgujPTazetI5lYo)
Additional Notes
The original PR for #2094 is #2092 (closed as 2 PR for the same issue were created due to miscommunication)