Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed migration script at applications/batch endpoint that added createdAt and status fields to applicants collection #2096

Conversation

yeshavyas27
Copy link
Contributor

@yeshavyas27 yeshavyas27 commented Aug 22, 2024

Date: 22 August, 2024

Developer Name: @yeshavyas27


Issue Ticket Number

Description

This PR removes the applications/batch endpoint and its related code that added createdAt and status fields to the applicants' collection.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Test Coverage

Unit Tests:
image

Integration Tests:
image

Additional Notes

The original PR for #2094 is #2092 (closed as 2 PR for the same issue were created due to miscommunication)

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add the reference of org PR

@iamitprakash
Copy link
Member

@yeshavyas27 #2094 is still open, then what what do you mean by "Closes"

@iamitprakash
Copy link
Member

@yeshavyas27 In desc it's says developer tested, can you add proof as well please

@yeshavyas27
Copy link
Contributor Author

yeshavyas27 commented Aug 22, 2024

@iamitprakash
I meant that the mentioned issue will be closed if this PR is merged, indicating that PR is related to that issue. I am sorry if I used the wrong terminology, let me know how I can correct this.

I have added a screenshot under 'Test Coverage'.
By org PR you mean this: #2092 right? I will add that, also can you tell me what was the problem in that PR?

Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeshavyas27 the test coverage screenshot that you shared is not up to the mark. can you please update a new one, You can compare your screenshot with others for reference

@iamitprakash
Copy link
Member

@iamitprakash I meant that the mentioned issue will be closed if this PR is merged, indicating that PR is related to that issue. I am sorry if I used the wrong terminology, let me know how I can correct this.

I have added a screenshot under 'Test Coverage'. By org PR you mean this: #2092 right? I will add that, also can you tell me what was the problem in that PR?

if this PR is in place #2092 do we really need this PR. CC- @vinit717

@iamitprakash
Copy link
Member

@yeshavyas27 I will wait for @vinit717 to approve first as he has more context on this

@vinit717
Copy link
Member

Make two PR's one for removing /batch route and it's code and another for removing /batch/update and it;s code and test

@yeshavyas27 yeshavyas27 force-pushed the remove-migration-script-that-adds-createdAt-status-fields-to-applicants-collection branch from 2706353 to c29bc92 Compare August 26, 2024 18:07
@yeshavyas27 yeshavyas27 force-pushed the remove-migration-script-that-adds-createdAt-status-fields-to-applicants-collection branch 2 times, most recently from 633d803 to 9003559 Compare August 26, 2024 18:37
@yeshavyas27 yeshavyas27 changed the title Removed migration script that added createdAt and status fields to applicants collection Removed migration script at /batch endpoint that added createdAt and status fields to applicants collection Aug 26, 2024
@yeshavyas27 yeshavyas27 changed the title Removed migration script at /batch endpoint that added createdAt and status fields to applicants collection Removed migration script at applications/batch endpoint that added createdAt and status fields to applicants collection Aug 26, 2024
@iamitprakash iamitprakash merged commit e000314 into Real-Dev-Squad:develop Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Migration Script for Adding createdAt and status Fields to Applicants Collection
4 participants