Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev feature flag for GET /logs API #2149

Merged

Conversation

samarpan1738
Copy link
Contributor

@samarpan1738 samarpan1738 commented Sep 12, 2024

Date: 13 Sep 2024

Developer Name: Samarpan Harit


Issue Ticket Number

Closes #2136

Description

  1. Remove 400 Bad request error when dev query param is not true
  2. Remove dev query param from next page link
  3. Update integration tests

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

NA

Test Coverage

NA

Additional Notes

Copy link
Contributor

@shubhdevelop shubhdevelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@samarpan1738 samarpan1738 force-pushed the 2136-remove-dev-ff-get-logs branch from 3bec47f to ec59a65 Compare September 20, 2024 20:06
@samarpan1738 samarpan1738 force-pushed the 2136-remove-dev-ff-get-logs branch from ec59a65 to 0c52cdf Compare September 21, 2024 19:36
@iamitprakash iamitprakash merged commit 63e945c into Real-Dev-Squad:develop Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dev feature flag from GET /logs API
4 participants