test: add test cases for notifications page #1001
Open
+166
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[My Site Migration] user status feature (Part - 1)
* basic setup and images and svg file * profile route and controller * changed urls.js file * reverted sinon package and fixed css * fixes of urls and yarn.lock and package.json file * changed toast import * moved profile fields to inside constants
* feat: add user status modal, controller for status * refactor: use constants for messages, urls, modify naming * chore: remove extra user_states in status modal * refactor: get current status method in status modal * refactor: status update for dev method * test: simulate mock inViewport for members data test --------- Co-authored-by: Achintya Chatterjee <[email protected]>
* feat: add css styles for user status component and modal * fix: styles for user status, status modal for mobile responsiveness * fix: remove duplicate css variables
* add integration tests for user-status components * fix set prop error and modify test case in status modal * add unit test for status route and component * add unit test for dateConversion, redirectAuth utils * fix: update test for user status, remove redirectAuth test * fix: status naming in user status component test --------- Co-authored-by: Vikas Singh <[email protected]> Co-authored-by: Achintya Chatterjee <[email protected]>
* feat: migrate from yarn to pnpm package manager * docs: update documentation for pnpm migration * chore: remove unrelated changes to live.js * chore: restore helpful comments in CI workflow * chore: trigger CI * chore: trigger CI
tejaskh3
changed the title
/notifications page test cases
Deploying www-rds with
|
| Latest commit: |
fbfe01e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://15cde3a2.www-rds.pages.dev |
| Branch Preview URL: | https://feat-notifications-page.www-rds.pages.dev |
Devashish08
approved these changes
Feb 5, 2025
Achintya-Chatterjee
previously approved these changes
Feb 6, 2025
iamitprakash
requested changes
Feb 6, 2025
There was a problem hiding this comment.
can you look into this to get coverage stats https://www.netguru.com/blog/test-coverage-in-ember-applications-with-ci-and-code-climate-integration
|
@iamitprakash We don't seem to have the coverage package installed. I feel that the coverage generation for this repo should be a separate task. It will be nice to automate the coverage and have it comment with the details from a bot |
ankushdharkar
requested changes
Feb 7, 2025
tejaskh3
changed the title
/notifications page test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 6 Feb, 2025
Developer Name: @tejaskh3
Issue Ticket Number:-
/notificationspage #993Description:
/notificationspageIs Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
Note