Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) : linting issue for window enviornment #999

Closed

Conversation

Devashish08
Copy link
Contributor

@Devashish08 Devashish08 commented Feb 4, 2025

Date: 5-02-2025

Developer Name: @Devashish08


Issue Ticket Number:-

Description:

pnpm lint:css:fix not working for window users

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

image

@Devashish08 Devashish08 closed this Feb 4, 2025
@tejaskh3
Copy link
Member

tejaskh3 commented Feb 5, 2025

@Devashish08 why did you close this?

@Devashish08 Devashish08 reopened this Feb 5, 2025
@Devashish08
Copy link
Contributor Author

@Devashish08 why did you close this?

need some one to verify it in window system

Copy link
Contributor

@Suvidh-kaushik Suvidh-kaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Suvidh-kaushik
Copy link
Contributor

Windows Working Proof:

pnpm_lint_fix.mp4

@tejaskh3 tejaskh3 changed the title fixed linting issue for window enviornment (fix) : linting issue for window enviornment Feb 5, 2025
@Devashish08
Copy link
Contributor Author

Devashish08 commented Feb 5, 2025

@Devashish08 why did you close this?

tejas js before approving these changes can you run these changes locally on your system that this changes work as intended and fixing css linting issue
@tejaskh3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants