Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tagmodal): revert the PF5/Modal import path change #2147

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Jan 15, 2025

This makes the TagModal and related components use the standard PF5/Modal import path. It was changed to use the "next" version of PF5/Modal and I believe it was not an intended change since it breaks the integration with other apps that still use the parameters for the standard version of PF5/Modal.

@gkarat gkarat self-assigned this Jan 15, 2025
@gkarat gkarat requested a review from a team January 15, 2025 15:25
Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with Inventory and all looks good again! Thank you @gkarat!

@gkarat gkarat merged commit 8da9e97 into RedHatInsights:master Jan 16, 2025
8 checks passed
@gkarat gkarat deleted the revert-modal-import-change branch January 16, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants