Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Shield): remove Unknown question mark icon #2154

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

xmicha82
Copy link
Contributor

Removed QuestionIcon from Shield component as per RHINENG-12939

@xmicha82 xmicha82 requested review from a team January 22, 2025 10:30
@@ -22,7 +21,12 @@ const Shield: React.FunctionComponent<ShieldProps> = ({ impact = 'N/A', hasLabel
color: attributes.color,
};

const badge = <Icon size={size}>{attributes.title === 'Unknown' ? <QuestionIcon {...badgeProps} /> : <SecurityIcon {...badgeProps} />}</Icon>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add a prop to show an icon and which icon, since there might be places where we actually do want to show an icon.

The default behaviour should still remain the same.

Copy link
Contributor

@johnsonm325 johnsonm325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmicha82 xmicha82 force-pushed the rm-unknown-icon branch 2 times, most recently from 0a29247 to d1ed0a3 Compare February 5, 2025 09:03
@johnsonm325 johnsonm325 merged commit e72ba9e into RedHatInsights:master Feb 7, 2025
8 checks passed
@xmicha82 xmicha82 deleted the rm-unknown-icon branch February 12, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants