Skip to content

Commit

Permalink
chore: remove useless lines and hostnames from tests and doc (#4244)
Browse files Browse the repository at this point in the history
- remove duplicate but useless test input in test_lvs
- remove unknow hostnames from tests and docstring

Signed-off-by: Xiangce Liu <[email protected]>
  • Loading branch information
xiangce authored Oct 10, 2024
1 parent 6d74018 commit 6e5ded5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 27 deletions.
4 changes: 2 additions & 2 deletions insights/parsers/dig.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class DigEdns(Dig):
;. IN SOA
;; ANSWER SECTION:
. 19766 IN SOA a.root-servers.net. nstld.verisign-grs.com. 2017120600 1800 900 604800 86400
. 19766 IN SOA a.root-servers.net. abc.com. 2017120600 1800 900 604800 86400
;; Query time: 22 msec
;; SERVER: 10.38.5.26#53(10.38.5.26)
Expand Down Expand Up @@ -151,7 +151,7 @@ class DigNoedns(Dig):
;. IN SOA
;; ANSWER SECTION:
. 20195 IN SOA a.root-servers.net. nstld.verisign-grs.com. 2017120600 1800 900 604800 86400
. 20195 IN SOA a.root-servers.net. abc.com. 2017120600 1800 900 604800 86400
;; Query time: 22 msec
;; SERVER: 10.38.5.26#53(10.38.5.26)
Expand Down
8 changes: 4 additions & 4 deletions insights/tests/parsers/test_dig.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
;. IN SOA
;; ANSWER SECTION:
. 19766 IN SOA a.root-servers.net. nstld.verisign-grs.com. 2017120600 1800 900 604800 86400
. 19766 IN SOA a.root-servers.net. abc.com. 2017120600 1800 900 604800 86400
;; Query time: 22 msec
;; SERVER: 10.38.5.26#53(10.38.5.26)
Expand All @@ -101,7 +101,7 @@
;. IN SOA
;; ANSWER SECTION:
. 19766 IN SOA a.root-servers.net. nstld.verisign-grs.com. 2017120600 1800 900 604800 86400
. 19766 IN SOA a.root-servers.net. abc.com. 2017120600 1800 900 604800 86400
;; Query time: 22 msec
;; SERVER: 10.38.5.26#53(10.38.5.26)
Expand All @@ -118,7 +118,7 @@
;. IN SOA
;; ANSWER SECTION:
. 20195 IN SOA a.root-servers.net. nstld.verisign-grs.com. 2017120600 1800 900 604800 86400
. 20195 IN SOA a.root-servers.net. abc.com. 2017120600 1800 900 604800 86400
;; Query time: 22 msec
;; SERVER: 10.38.5.26#53(10.38.5.26)
Expand All @@ -137,7 +137,7 @@
;; AUTHORITY SECTION:
com. 900 IN SOA a.gtld-servers.net.
nstld.verisign-grs.com. 1508851057 1800 900 604800 86400
abc.com. 1508851057 1800 900 604800 86400
;; Query time: 29 msec
;; SERVER: 10.38.5.26#53(10.38.5.26)
Expand Down
21 changes: 0 additions & 21 deletions insights/tests/parsers/test_lvs.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,27 +53,6 @@
Unrecognised field: data_percent
""".strip()

LVS_INFO_ERROR = """
WARNING: Locking disabled. Be careful! This could corrupt your metadata.
Logical Volume Fields
---------------------
lv_all - All fields in this section.
lv_uuid - Unique identifier.
lv_name - Name. LVs created for internal us
Physical Volume Label Fields
----------------------------
pv_all - All fields in this section.
pv_fmt - Type of metadata.
pv_uuid - Unique identifier.
Physical Volume Segment Fields
------------------------------
pvseg_all - All fields in this section.
pvseg_start - Physical Extent number of start of segment.
pvseg_size - Number of extents in segment.
Unrecognised field: data_percent
""".strip()

LVS_ROOT_INFO = {
"MergeFailed": "unknown",
"#Seg": "1",
Expand Down

0 comments on commit 6e5ded5

Please sign in to comment.