Deprecate insights.core.scannable & engine_log parser #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following will be deprecated after insights-core-3.2.25: * insights.core.scannable: Better use the `core.Parser` with filter. * insights.parsers.engine_log: Use insights.parsers.ovirt_engine_log instead. Signed-off-by: Sachin Patil <[email protected]>
bfahr
approved these changes
Oct 11, 2022
|
@psachin - Marking the BTW, Is the PR ready to merge? I see there is |
psachin
changed the title
xiangce
pushed a commit
that referenced
this pull request
Oct 13, 2022
The following will be deprecated after insights-core-3.2.25: * insights.core.scannable: Better use the `core.Parser` with filter. * insights.parsers.engine_log: Use insights.parsers.ovirt_engine_log instead. Signed-off-by: Sachin Patil <[email protected]> (cherry picked from commit 53838ad)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
The following will be deprecated after insights-core-3.2.25: * insights.core.scannable: Better use the `core.Parser` with filter. * insights.parsers.engine_log: Use insights.parsers.ovirt_engine_log instead. Signed-off-by: Sachin Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete Description of Additions/Changes:
The following will be deprecated after insights-core-3.2.25:
core.Parserwith filter.Signed-off-by: Sachin Patil [email protected]
All Pull Requests:
Check all that apply: