Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip empty spec only when collecting #4183

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: Skip empty spec only when collecting #4183

merged 1 commit into from
Aug 9, 2024

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Aug 6, 2024 •
edited
Loading

  • When running plugins, print a debug information only for
    empty spec, but not raise Exception
  • As before, the empty spec will be collected, but the
    reason will be recorded as an ContentException in its
    meta_data JSON
  • JIRA: RHINENG-11843
  • And change to show the full real path instead of relative path
    in the debug message
  • Fix the relevant test of compliance ds
  • fix OSError: [Errno 90] Message too long #4180

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

@xiangce xiangce requested a review from JoySnow August 6, 2024 07:25
@xiangce xiangce changed the title chore: Skip empty spec only when doing collection chore: Skip empty spec only when collecting Aug 6, 2024
@xiangce
chore: Skip empty spec only when collecting
3442761 
- When running plugins just print a debug information for empty
  spec, instead of raising an Exception
- As before the empty spec will be collected, but the reason
  will be recorded as an ContentException in its meta_data JSON
- Change to show the full real path instead of relative path
  in the debug message
- Fix the relevant test of complaince ds

Signed-off-by: Xiangce Liu <[email protected]>
@xiangce xiangce mentioned this pull request Aug 7, 2024
Closed
@xiangce xiangce requested a review from ryan-blakley August 7, 2024 06:37
@xiangce
Copy link
Contributor Author

xiangce commented Aug 7, 2024 •
edited
Loading

@ryan-blakley - Would you mind reviewing this PR, it would also fix the issue #4180

@xiangce xiangce changed the title chore: Skip empty spec only when collecting fix: Skip empty spec only when collecting Aug 8, 2024
@xiangce xiangce merged commit d4b092a into master Aug 9, 2024
10 of 11 checks passed
@xiangce xiangce deleted the skip_empty branch August 9, 2024 08:26
chenlizhong pushed a commit that referenced this pull request Aug 15, 2024
@xiangce @chenlizhong
chore: Skip empty spec only when collecting (#4183)
f1bd4f4 
- When running plugins, for empty specs, print debug
  information only, but do not raise Exceptions
- The same as before, the empty spec will be collected,
  and the reason will be recorded as an ContentException
  into its meta_data JSON
- JIRA: RHINENG-11843
- And change to show the full real path instead of relative path
  in the debug message
- Fix the relevant tests of compliance ds

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit d4b092a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-blakley ryan-blakley ryan-blakley approved these changes

@JoySnow JoySnow JoySnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSError: [Errno 90] Message too long
3 participants
@xiangce @ryan-blakley @JoySnow