do not collect metadata stuff on client side #4250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4250 +/- ##
==========================================
+ Coverage 76.97% 77.02% +0.04%
==========================================
Files 735 735
Lines 41300 41223 -77
Branches 8770 8761 -9
==========================================
- Hits 31791 31751 -40
+ Misses 8441 8404 -37
Partials 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
added
client
xiangce
force-pushed
the
no_client_metadata
branch
from
af9047d to
429b7ad
Compare
xiangce
force-pushed
the
no_client_metadata
branch
from
429b7ad to
acef0cd
Compare
xiangce
changed the title
- "metadata" was already collected by core collection specs - This change needs QE tests for all dependencies - Jira: RHINENG-7581 Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
no_client_metadata
branch
from
acef0cd to
9a2f634
Compare
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangce Liu [email protected]
All Pull Requests:
Check all that apply: