fix(ci): Use dynamic repo URL for python26-test #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The harcoded RedHatInsights URL makes the Python 2.6 tests fail when a pull request is created in a fork. Using a dynamic URLs makes the GitHub Action to clone from the fork and use the code in the pull request. github.repositoryUrl variable can’t be used, because cloning using git:// protocol fails. HTTPS url is thus composed instead. Card IDs: * RHINENG-14956 Signed-off-by: Štěpán Tomsa <[email protected]>
|
May I ask for a review, @xiangce? 🙇🏻♂️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4314 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 765 765
Lines 41753 41753
Branches 8815 8815
=======================================
Hits 32221 32221
Misses 8464 8464
Partials 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
pushed a commit
that referenced
this pull request
Jan 2, 2025
The harcoded RedHatInsights URL makes the Python 2.6 tests fail when a pull request is created in a fork. Using a dynamic URLs makes the GitHub Action to clone from the fork and use the code in the pull request. github.repositoryUrl variable can’t be used, because cloning using git:// protocol fails. HTTPS url is thus composed instead. Card IDs: * RHINENG-14956 Signed-off-by: Štěpán Tomsa <[email protected]> (cherry picked from commit dd934a3)
xiangce
pushed a commit
that referenced
this pull request
Jan 2, 2025
The harcoded RedHatInsights URL makes the Python 2.6 tests fail when a pull request is created in a fork. Using a dynamic URLs makes the GitHub Action to clone from the fork and use the code in the pull request. github.repositoryUrl variable can’t be used, because cloning using git:// protocol fails. HTTPS url is thus composed instead. Card IDs: * RHINENG-14956 Signed-off-by: Štěpán Tomsa <[email protected]> (cherry picked from commit dd934a3) (cherry picked from commit 2b81ea2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The harcoded RedHatInsights URL makes the Python 2.6 tests fail when a pull request is created in a fork. Using a dynamic URLs makes the GitHub Action to clone from the fork and use the code in the pull request.
github.repositoryUrl variable can’t be used, because cloning using git:// protocol fails. HTTPS url is thus composed instead.
Card IDs: