fix: do not print collection messages for compliance apiv2 options #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RHINENG-14959 - When any compliance apiv2 options is specified nothing will be collected, hence data collection relevant messages should not be printed to console. The rm_conf which includes the file/content redaction is also cleared for compliance apiv2 for this reason. Signed-off-by: Xiangce Liu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4319 +/- ##
==========================================
- Coverage 77.18% 77.18% -0.01%
==========================================
Files 765 765
Lines 41770 41773 +3
Branches 8821 8822 +1
==========================================
+ Hits 32240 32241 +1
- Misses 8463 8464 +1
- Partials 1067 1068 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xiangce Liu <[email protected]>
JoySnow
approved these changes
Dec 20, 2024
|
QE test passed, merging to master |
xiangce
added a commit
that referenced
this pull request
Jan 2, 2025
…4319) - RHINENG-14959 - When any compliance apiv2 options are specified, nothing will be collected, hence data collection relevant messages should not be printed to console. The rm_conf which includes the file/content redaction is also cleared for compliance apiv2 for this reason. Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 747e52d)
xiangce
added a commit
that referenced
this pull request
Jan 2, 2025
…4319) - RHINENG-14959 - When any compliance apiv2 options are specified, nothing will be collected, hence data collection relevant messages should not be printed to console. The rm_conf which includes the file/content redaction is also cleared for compliance apiv2 for this reason. Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 747e52d) (cherry picked from commit 06d2121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here