Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new command fwupdmgr to spec.fw_security #4320

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

JoySnow
Copy link
Collaborator

@JoySnow JoySnow commented Dec 20, 2024

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

RHINENG-15022 , rely on the merge of #4317

From KCS#5436071, the command fwupdmgr supports since RHEL7.4.
As we need to keep both command for spec fw_security for a while, use first_of instead of creating another spec for command fwupdmgr.

@JoySnow JoySnow requested a review from xiangce December 20, 2024 08:39
@JoySnow JoySnow force-pushed the spec-fwupdmgr--json branch from b159247 to 599a8c5 Compare December 23, 2024 08:03
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (f60b00a) to head (599a8c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4320   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files         766      766           
  Lines       41799    41799           
  Branches     8830     8830           
=======================================
  Hits        32267    32267           
  Misses       8464     8464           
  Partials     1068     1068           
Flag Coverage Δ
unittests 77.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangce xiangce merged commit 409aff8 into RedHatInsights:master Dec 23, 2024
15 of 16 checks passed
@JoySnow JoySnow deleted the spec-fwupdmgr--json branch December 23, 2024 09:05
xiangce pushed a commit that referenced this pull request Jan 2, 2025
Signed-off-by: Xiaoxue Wang <[email protected]>
(cherry picked from commit 409aff8)
xiangce pushed a commit that referenced this pull request Jan 2, 2025
Signed-off-by: Xiaoxue Wang <[email protected]>
(cherry picked from commit 409aff8)
(cherry picked from commit 70d22de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants