refactor: split spec_cleaner to multiple sub-modules #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4324 +/- ##
==========================================
+ Coverage 76.99% 77.07% +0.08%
==========================================
Files 735 742 +7
Lines 41311 41361 +50
Branches 8773 8774 +1
==========================================
+ Hits 31809 31881 +72
+ Misses 8438 8429 -9
+ Partials 1064 1051 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
force-pushed
the
refactor_cleaner
branch
2 times, most recently
from
85bdcc5 to
6476011
Compare
xiangce
force-pushed
the
refactor_cleaner
branch
from
6476011 to
eee70eb
Compare
This is a preparation for the support of IPv6 and MAC address obfuscation. By splitting it to multiple sub-modules, it will be easy for adding new modules, e.g. IPv6 and MAC obfuscation. Jira: RHINENG-15077 - replace the `get_obfuscate_functions` with a new keyword argument `width`, for specs that need to keep the original words width, this `width` needs to be set by hand before content cleaning. In the future, it will be moved to the RegistryPoint for user to set by hand per specs. - the processing of "password" and "keyword" is kind of "obfuscation" which replace the potential `password value` and specified `keywords` to kind of fixed strings/words, so moved it to the obfuscation module. User can exclude it by specifying it with, e.g. "no_obfuscate=['password']" while adding its RegistryPoint in `insights.specs.Specs`. Jira: RHINENG-14756 Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
refactor_cleaner
branch
from
eee70eb to
135fd52
Compare
JoySnow
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for IPv6 and MAC address obfuscation. By splitting it to multiple sub-modules, it will be easy for adding new modules, e.g. IPv6 and MAC obfuscation. Jira: RHINENG-15077
get_obfuscate_functionswith a new keyword argumentwidth, for specs that need to keep the original words width, thiswidthneeds to be set by hand before content cleaning. In the future, it will be moved to the RegistryPoint for user to set by hand per specs.password valueand specifiedkeywordsto kind of fixed strings/words, so moved it to the obfuscation module. User can exclude it by specifying it with, e.g. "no_obfuscate=['password']" while adding its RegistryPoint ininsights.specs.Specs. Jira: RHINENG-14756All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here