remove support of python 2.6 #4325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4325 +/- ##
==========================================
+ Coverage 76.99% 77.01% +0.01%
==========================================
Files 735 735
Lines 41311 41298 -13
Branches 8773 8771 -2
==========================================
- Hits 31809 31807 -2
+ Misses 8438 8430 -8
+ Partials 1064 1061 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
force-pushed
the
remove_py26
branch
2 times, most recently
from
408d3fa to
b1b61c7
Compare
Jira: RHINENG-12167 - this change should not be applied to the "rhel_6" branch - only explicit support of py26 is removed - remove unused files/modules, e.g. .collections.py, Jenkinsfile, shippable.yml insights/contrib/ElementPath/Tree.py insights/contrib/importlib.py Signed-off-by: Xiangce Liu <[email protected]>
|
Hi @m-horky, @Glutexo and @JoySnow - This PR is trying to remove all Py26 relevant code from the master branch (hence the 3.0 branch). Please take a look whenever free, for any missed Py26 code slices, please let me know. Thanks in advance. PS. the 3.0 branch leads to rhel7/8/9/10 eggs for now, individual branch for each of RHEL will be created when it's required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: RHINENG-12167
.collections.py, Jenkinsfile, shippable.yml
insights/contrib/ElementPath/Tree.py
insights/contrib/importlib.py
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here