Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spec parser and combiner for grubby_info #4329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoySnow
Copy link
Collaborator

@JoySnow JoySnow commented Jan 8, 2025

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

RHINENG-15118

  • add new spec and parser for grubby_info_all
  • add combiner for grubby commands

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (9c64871) to head (c1f020f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4329      +/-   ##
==========================================
+ Coverage   76.98%   77.03%   +0.04%     
==========================================
  Files         735      736       +1     
  Lines       41306    41366      +60     
  Branches     8772     8789      +17     
==========================================
+ Hits        31801    31865      +64     
+ Misses       8439     8438       -1     
+ Partials     1066     1063       -3     
Flag Coverage Δ
unittests 77.01% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoySnow JoySnow requested a review from xiangce January 8, 2025 10:14
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may use this new Grubby combiner to deprecate the existing BootLoaderEntries

Attributes:
boot_entries (dict): All boot entries indexed by the entry "index"
default_index (int): the numeric index of the current default boot entry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a combiner, it would be good to combine more useful attribute here, e.g. devs can use the combiner rather than access each single parser to fetch particular info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants