Don't allow empty strings for Service Account fields (#2087)

RedHatInsights · Nov 22, 2024 · 72341b4 · 72341b4
1 parent 94d4e93
commit 72341b4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/app/auth/identity.py b/app/auth/identity.py
@@ -167,8 +167,8 @@ class SystemIdentitySchema(IdentityBaseSchema):
 
 
 class ServiceAccountInfoIdentitySchema(IdentityBaseSchema):
-    client_id = m.fields.Str(required=True)
-    username = m.fields.Str(required=True)
+    client_id = m.fields.Str(required=True, validate=m.validate.Length(min=1))
+    username = m.fields.Str(required=True, validate=m.validate.Length(min=1))
 
 
 class ServiceAccountIdentitySchema(IdentityBaseSchema):

diff --git a/tests/test_unit.py b/tests/test_unit.py
@@ -231,7 +231,15 @@ def test_invalid_system_obj(self):
 
     def test_invalid_service_account_obj(self):
         test_identity = deepcopy(SERVICE_ACCOUNT_IDENTITY)
-        service_account_objects = [None, ""]
+        service_account_objects = [
+            None,
+            "",
+            {
+                "client_id": SERVICE_ACCOUNT_IDENTITY["service_account"]["client_id"],
+                "username": "",
+            },
+            {"client_id": "", "username": SERVICE_ACCOUNT_IDENTITY["service_account"]["username"]},
+        ]
         for service_account_object in service_account_objects:
             with self.subTest(service_account_object=service_account_object):
                 test_identity["service_account"] = service_account_object