Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHINENG-15973] Update System Profile Schema #2270

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

strider
Copy link
Contributor

@strider strider commented Feb 13, 2025

This PR is being created to update the System Profile Schema, keeping it in sync with RedHatInsights/inventory-schemas#147.

Signed-off-by: Gaël Chamoulaud [email protected]

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Overview

This PR is being created to address RHINENG-15973.

PR Checklist

  • Keep PR title short, ideally under 72 characters
  • Descriptive comments provided in complex code blocks
  • Include raw query examples in the PR description, if adding/modifying SQL query
  • Tests: validate optimal/expected output
  • Tests: validate exceptions and failure scenarios
  • Tests: edge cases
  • Recovers or fails gracefully during potential resource outages (e.g. DB, Kafka)
  • Uses type hinting, if convenient
  • Documentation, if this PR changes the way other services interact with host inventory
  • Links to related PRs

Secure Coding Practices Documentation Reference

You can find documentation on this checklist here.

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@strider strider requested a review from a team as a code owner February 13, 2025 13:08
@strider strider requested a review from JoySnow February 13, 2025 13:10
@strider strider force-pushed the update-system-profile-schema branch from 085d44c to a0b87f0 Compare February 13, 2025 13:17
@strider strider changed the title Update System Profile Schema [RHINENG-15973] Update System Profile Schema Feb 13, 2025
Copy link
Contributor

@FabriciaDinizRH FabriciaDinizRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strider strider force-pushed the update-system-profile-schema branch from a0b87f0 to a54d64b Compare February 13, 2025 14:20
Copy link

@JoySnow JoySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strider Thanks for propagate the schema changes to HBI. LGTM definitely.

This PR is being created to update the System Profile Schema, keeping it
in sync with RedHatInsights/inventory-schemas#147.

Signed-off-by: Gaël Chamoulaud <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@strider strider force-pushed the update-system-profile-schema branch from a54d64b to ab75ac9 Compare February 13, 2025 15:45
@kruai kruai merged commit ffa3cab into RedHatInsights:master Feb 14, 2025
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants