Formatting: convert indent from visual to hanging #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegorafrh
approved these changes
Jul 23, 2019
Glutexo
changed the title
Glutexo
changed the title
|
This pull request has been approved. Can we merge it? |
Glutexo
force-pushed
the
black_indentation
branch
from
3efe477 to
222b63a
Compare
|
Rebased, mergeable again. |
catastrophe-brandon
approved these changes
Jul 26, 2019
Glutexo
force-pushed
the
black_indentation
branch
from
222b63a to
38a586a
Compare
|
Rebased to resolve conflicts. |
Covert all visual indentation to hanging, preferred by Black. Some lines were transformed to have an optimal length. Lines that violates Black’s standards only in terms of length, but don’t in terms of the indentation were not touched. Split multiline strings have been recompiled to have the longest lines possible.
Glutexo
force-pushed
the
black_indentation
branch
from
38a586a to
5b0aed8
Compare
|
And one more conflict-resolving rebase. |
|
I manually resolved the conflict and pushed this as commit 257e0de. |
Glutexo
commented
Jul 29, 2019
| {"display_name": ""}, | ||
| ] | ||
| invalid_data_list = [ | ||
| {"ansible_host": "a"*256}, |
There was a problem hiding this comment.
Whitespace fix has not survived the merge.
| "infrastructure_vendor": "i" * 101, | ||
| "cloud_provider": "i" * 101}] | ||
| system_profiles = [ | ||
| {"infrastructure_type": "i"*101, "infrastructure_vendor": "i"*101, "cloud_provider": "i"*101} |
There was a problem hiding this comment.
Whitespace fixes have not survived the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covert all visual indentation to hanging, preferred by Black. Some lines were transformed to have an optimal length. Lines that violates Black’s standards only in terms of length, but don’t in terms of the indentation were not touched. Split multiline strings have been recompiled to have the longest lines possible.
This is a part towards a cleanly formatted code that can be transformed by Black on every commit. #335