Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-36586] Various improvements of email connector: #3167

Conversation

g-duval
Copy link
Contributor

@g-duval g-duval commented Dec 4, 2024

[RHCLOUD-36586] Various improvement of email connector:

  • refactor tests
  • use a jackson mapper to read incoming payload data
  • rename external criteria to extenal criterion

@g-duval g-duval changed the title [RHCLOUD-36586] Various improvement of email connector: [RHCLOUD-36586] Various improvements of email connector: Dec 4, 2024
@g-duval g-duval marked this pull request as draft December 5, 2024 08:41
@g-duval g-duval marked this pull request as ready for review December 9, 2024 13:53
@g-duval
Copy link
Contributor Author

g-duval commented Dec 9, 2024

/retest

@gwenneg
Copy link
Member

gwenneg commented Dec 9, 2024

/konflux

@g-duval
Copy link
Contributor Author

g-duval commented Dec 12, 2024

/retest

@g-duval g-duval force-pushed the RHCLOUD-36586_variousImprovementOfEmailConnector branch 3 times, most recently from 535884f to 11e88e1 Compare December 17, 2024 09:59
* refactor tests
* use a jackson mapper to read incoming payload data
@g-duval g-duval force-pushed the RHCLOUD-36586_variousImprovementOfEmailConnector branch from 11e88e1 to 7fb4c7d Compare December 17, 2024 10:00
Copy link
Member

@MikelAlejoBR MikelAlejoBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@g-duval g-duval merged commit 953a683 into RedHatInsights:master Dec 17, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants