Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ephemeral): increase max_stack_depth #1077

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Feb 19, 2024

RHINENG-8335

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Feb 19, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-8335

@psegedy psegedy force-pushed the ephemeral_stack_depth branch 2 times, most recently from 865c876 to cc0f048 Compare February 19, 2024 21:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2529bcf) 61.32% compared to head (f4b0d25) 61.26%.

Files Patch % Lines
vmaas/reposcan/database/upgrade.py 0.00% 5 Missing ⚠️
vmaas/common/config.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
- Coverage   61.32%   61.26%   -0.06%     
==========================================
  Files          69       69              
  Lines        6322     6328       +6     
==========================================
  Hits         3877     3877              
- Misses       2445     2451       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy marked this pull request as ready for review February 19, 2024 22:24
@psegedy psegedy requested a review from jdobes February 19, 2024 22:24
@psegedy psegedy force-pushed the ephemeral_stack_depth branch 2 times, most recently from 25c9feb to ac0db4c Compare February 20, 2024 15:06
@psegedy psegedy force-pushed the ephemeral_stack_depth branch from ac0db4c to f4b0d25 Compare February 20, 2024 15:30
@jdobes jdobes merged commit 6af693d into RedHatInsights:master Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants