Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webapp): add go controller for errata endpoint #1230

Merged
merged 1 commit into from
Jan 23, 2025
Merged

feat(webapp): add go controller for errata endpoint #1230

merged 1 commit into from
Jan 23, 2025

Conversation

Dugowitch
Copy link
Contributor

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking Jira Linking
Copy link

jira-linking bot commented Jan 16, 2025 •
edited
Loading

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-13555

@Dugowitch Dugowitch requested a review from psegedy January 17, 2025 16:46
@psegedy
Copy link
Member

psegedy commented Jan 20, 2025

I set ENABLE_GO_ERRATA: "true" for ephemeral env to see tests results for new endpoints

@psegedy
Copy link
Member

psegedy commented Jan 20, 2025

/retest

@Dugowitch Dugowitch force-pushed the errata-controller branch 2 times, most recently from 8def70e to 3421f06 Compare January 21, 2025 08:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 62.27%. Comparing base (5a56460) to head (c5e6fb0).
Report is 181 commits behind head on master.

Files with missing lines Patch % Lines
vmaas-go/webapp/controllers/errata.go 0.00% 29 Missing ⚠️
vmaas-go/webapp/routes/routes.go 0.00% 4 Missing ⚠️
vmaas-go/base/utils/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
- Coverage   62.98%   62.27%   -0.71%     
==========================================
  Files          70       90      +20     
  Lines        6800     6789      -11     
==========================================
- Hits         4283     4228      -55     
- Misses       2517     2552      +35     
- Partials        0        9       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dugowitch Dugowitch marked this pull request as ready for review January 21, 2025 09:14
@mtclinton
Copy link
Contributor

/retest

3 similar comments
@Dugowitch
Copy link
Contributor Author

/retest

@mtclinton
Copy link
Contributor

/retest

@psegedy
Copy link
Member

psegedy commented Jan 22, 2025

/retest

@mtclinton
Copy link
Contributor

/retest

@Dugowitch Dugowitch merged commit ea1011c into RedHatInsights:master Jan 23, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psegedy psegedy psegedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dugowitch @psegedy @codecov-commenter @mtclinton