Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user logic #13

Merged
merged 9 commits into from
Sep 5, 2024
Merged

Update user logic #13

merged 9 commits into from
Sep 5, 2024

Conversation

bolajahmad
Copy link
Collaborator

This PR adds logic to allows users to update their registered information. Users are allowed to update information like,

  • Email address
  • Telegram handle
  • Notifiers desired

User ID must be provided

Fixes
Adds a fix to prevent users from registering with an ID. IDs must be autogenerated by the DB.
Refactored code in the users db crate.

@bolajahmad bolajahmad requested a review from Szegoo August 27, 2024 10:57
@Szegoo
Copy link
Member

Szegoo commented Aug 27, 2024

Adds a fix to prevent users from registering with an ID. IDs must be autogenerated by the DB.

I changed this on purpose. The current u32 we use for id is just a place holder. This will be the address of the user. Please revert the change

@bolajahmad
Copy link
Collaborator Author

Adds a fix to prevent users from registering with an ID. IDs must be autogenerated by the DB.

I changed this on purpose. The current u32 we use for id is just a place holder. This will be the address of the user. Please revert the change

Yes, as we discussed I already reverted this logic. The ID is the address so it must be provided during registration and cannot be changed once registered.

@bolajahmad bolajahmad merged commit 5d4dbbf into main Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants