List and ListStream implementation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrebsguedes
force-pushed
the
ag-list-op
branch
from
c96af1e to
1fcd6c9
Compare
|
will try take a look at this tomorrow, but Justin probably better placed to review one random thought: i wonder if we should maybe just put this all in its own file, since it's pretty separate to the get/put implementation -- would that make the codebase more maintainable? Just a passing thought, so take it or leave it 😊 |
andrebsguedes
force-pushed
the
ag-list-op
branch
from
ac702f0 to
7181414
Compare
jfunstonRAI
reviewed
Feb 1, 2024
jfunstonRAI
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes list functionality through buffered and streaming APIs