Merge 7oxicshadow's Linux fixes #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Add the ability to stop the render thread *Add the ability to stop the ngen thread *Add the ability to detect the window close event *Add gl_context_destroy function *Close any open controllers *Allows the nvmem to save
pi2 should now exit cleanly
pi2 should now save settings
general formatting clean-up
Note: Raspberry pi requires keyboard.cfg in /mappings
to bind esc key
This is required for Launchers that make extensive use of the "-config" command line option. Without it the RTC always resets to default because it parses a virtual config instead of the emu.cfg file. RetroPie is one of the main usage cases for this mode. If any RetroPie devs try these changes, be sure to open the Makefile and enable NO_VIRTUAL_CONFIG at the top of the file. I have rearanged the cfgopen() and parsecommandline() functions to accomodate this. Add minor fixes for tab/space corrections. Add minor fix for missing guards around closing evdev controllers.
|
WOAW great work, thanks a lot |
joolswills
reviewed
Dec 29, 2017
| @@ -331,7 +333,7 @@ | |||
| } else if (ie.code == controller->mapping->Btn_Start) { | |||
| SET_FLAG(kcode[port], DC_BTN_START, ie.value); | |||
| } else if (ie.code == controller->mapping->Btn_Escape) { | |||
| die("death by escape key"); | |||
| start_shutdown(); | |||
joolswills
reviewed
Dec 29, 2017
| ngen_terminate(); | ||
| } | ||
|
|
||
| #endif |
|
there are various whitespace/indent issues that should be fixed. |
|
the PR also contains merge commits - it needs rebasing. |
|
Do the commits need to be squashed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7oxicshadow fixed the reicast Linux build to exit cleanly so it saves settings on exit, rather than crashing. I've built and tested this on my RPi3 and it works like a charm. This PR merges in those fixes to the RetroPie branch of reicast.
Here's a thread where the patch has been discussed, and (after I posted a binary) others tried it and reported success: https://retropie.org.uk/forum/topic/364/every-time-i-play-dreamcast-displays-the-setting-screen-time-date/64