Skip to content

Commit

Permalink
Breakpad is currently broken on Windows. Manually call the hook
Browse files Browse the repository at this point in the history
  • Loading branch information
RichardTea committed May 10, 2024
1 parent f8e329c commit 05eb791
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 4 deletions.
4 changes: 1 addition & 3 deletions libs.pri
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ win32 {
DEFINES += USE_BREAKPAD

# Config breakpad if required
system(if not exist $$shell_quote($${BREAKPAD_PATH}) ( mkdir $$shell_quote($${BREAKPAD_PATH}) && cd $$shell_quote($${BREAKPAD_PATH}) && $$shell_quote($${DEPOT_TOOLS_PATH}\fetch.bat) breakpad))
# Update Breakpad
system(cd $$shell_quote($${BREAKPAD_PATH}) && $$shell_quote($${DEPOT_TOOLS_PATH}\gclient.bat) sync)
system(set "PATH=$${DEPOT_TOOLS_PATH};%PATH%" && $${LIBS_PATH}/update_breakpad_win.bat)

LIBS += -luser32
INCLUDEPATH += {BREAKPAD_PATH}/src/src/
Expand Down
28 changes: 28 additions & 0 deletions libs/update_breakpad_win.bat
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
@echo off

cd %~dp0

if exist breakpad (
goto update_gclient
)

:install_breakpad
echo Installing Breakpad for the first time

mkdir breakpad
pushd breakpad
call fetch.bat breakpad

if errorlevel 1 (
echo Working around breakpad bug on Windows
python3.bat src\src\tools\python\deps-to-manifest.py src/DEPS src/default.xml
)

popd

:update_gclient
pushd breakpad
call gclient.bat sync
popd

EXIT /B
2 changes: 1 addition & 1 deletion tools/depot_tools
Submodule depot_tools updated from 8fbdc5 to 6e32e9

0 comments on commit 05eb791

Please sign in to comment.