Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component based bundling #27

Merged
merged 12 commits into from
Jan 24, 2024
Merged

Component based bundling #27

merged 12 commits into from
Jan 24, 2024

Conversation

hypebright
Copy link
Contributor

Adds support for component based bundling and will close #26

@hypebright
Copy link
Contributor Author

@DivadNojnarg this is what I had in mind, what are your thoughts?

It works as expected, and current functionality for monolithic bundling is still intact. Might need some more checks/cleanup when it comes to names. If a .js file is called hello-main.js for example, the dep function will also be called add_hello-main_deps, which is not that nice, but perhaps exactly what you would expect 🤔. Might also be responsibility of the user, in that case a message will do.

@hypebright hypebright removed the request for review from DivadNojnarg January 24, 2024 08:24
@DivadNojnarg
Copy link
Member

How about transforming add_hello-main_deps into add_hello_main_deps? At least we can check for -. Other characters will be left to the user responsibility and leave a message.

@hypebright hypebright marked this pull request as ready for review January 24, 2024 12:24
Copy link
Member

@DivadNojnarg DivadNojnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hypebright.

@DivadNojnarg DivadNojnarg merged commit 4f37f3d into master Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance esbuild configuration for component based bundling
2 participants