Cleanups #1
Open
Cleanups #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was confusing - the file in packaging macos hasn't been used since we switched to building with cmake something like seven years ago. Also add missing keys to the actual Info.plist skeleton. Signed-off-by: Dirk Hohndel <[email protected]>
Signed-off-by: Dirk Hohndel <[email protected]>
If we are building our own version of libusb, let's build a current one (because current libmtp relies on that). Signed-off-by: Dirk Hohndel <[email protected]>
This is required to compile it on ARM64 Macs (and of course also is the right thing to do overall). Signed-off-by: Dirk Hohndel <[email protected]>
The OpenSSL configure script requires us to pass in the correct build spec. Signed-off-by: Dirk Hohndel <[email protected]>
Simply removing outdated things that will be in the way. Signed-off-by: Dirk Hohndel <[email protected]>
Signed-off-by: Dirk Hohndel <[email protected]>
These no longer compile with Qt6 - but they are already duplicated in C++ code, anyway. So we can simply remove them. Signed-off-by: Dirk Hohndel <[email protected]>
These should be handled as logical OR operations as they are bits. Signed-off-by: Dirk Hohndel <[email protected]>
I'm a abit confused why that didn't cause an error with Qt5. Signed-off-by: Dirk Hohndel <[email protected]>
This has bugged me forever. The existing file creates a warning on every single compiler invocation. I really need to figure out if I can get this fixed upstream. But while I'm at it, I submitted it here to make it easier to spot warnings in the build output. Signed-off-by: Dirk Hohndel <[email protected]>
We do want the -Wfloat-conversion warnings where they point out potential bugs. But they are very distracting when they are triggered by floating point literals (which the standard defines as double) passed to a function expecting float arguments. Signed-off-by: Dirk Hohndel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Changes made:
Related issues:
Additional information:
Release note:
Documentation change:
Mentions: