Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sitemap for images to resolve indexing issues with webp images #1389

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add new sitemap for images to resolve indexing issues with webp images #1389

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b1cad36
Add new sitemap for images to resolve indexing issues with webp images
samnixon87 Sep 19, 2024
56256a4
Merge latest changes from main
samnixon87 Sep 19, 2024
a6078f9
Fix build error
samnixon87 Sep 19, 2024
b0264f0
Revert and make sure it actually builds
samnixon87 Sep 19, 2024
407910d
add gatsby-plugin-image ref in the gatsby-config
samnixon87 Sep 20, 2024
4b63c32
Try and resolve build error where sitemap doesn't have access to the …
samnixon87 Sep 20, 2024
49fb466
Try and handle images without data
samnixon87 Sep 20, 2024
6dfe687
Fix var name so it's not DISLallow
samnixon87 Sep 20, 2024
1b7af37
Tweak to better handle errors
samnixon87 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions gatsby-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,34 @@ module.exports = {
{
resolve: 'gatsby-plugin-sitemap',
options: {
output: `/sitemap-index`,
excludes: DISLALLOW_LIST,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw this. Can you rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik it should match the other sitemaps, which are currently only on sitemap-index. sitemap-index should collect all sitemaps though, so I'll change and see what happens

Copy link
Contributor

@Xantier Xantier Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant the typo here. DIESEL-ALLOW

Copy link
Contributor Author

@samnixon87 samnixon87 Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A DT var that I didn't catch. Changed

query: `
{
allSitePage {
nodes {
path
}
}
allFile(filter: { extension: { regex: "/(jpg|jpeg|png|webp)/" } }) {
nodes {
publicURL
}
}
}
`,
serialize: ({ path, allFile }) => {
const images = allFile.nodes.map((node) => ({
url: `https://roadie.io${node.publicURL}`,
}));

return {
url: path,
changefreq: `daily`,
priority: 0.7,
images,
};
},
},
},

Expand Down
Loading