Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer SCM Auth over GitHub auth on GH plugins #1783

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Xantier
Copy link
Contributor

@Xantier Xantier commented Jan 9, 2025

Update '@roadiehq/backstage-plugin-github-pull-requests' and '@roadiehq/backstage-plugin-github-insights' to use SCM auth instead of GitHub auth to allow multiple integrations to work at the same time.

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

…hq/backstage-plugin-github-insights' to use SCM auth instead of GitHub auth to allow multiple integrations to work at the same time.
@Xantier Xantier changed the title Update '@roadiehq/backstage-plugin-github-pull-requests' and '@roadiehq/backstage-plugin-github-insights' to use SCM auth instead of GitHub auth to allow multiple integrations to work at the same time. Prefer SCM Auth over GitHub auth on GH plugins Jan 9, 2025
@Xantier Xantier marked this pull request as ready for review January 10, 2025 10:39
@Xantier Xantier requested a review from a team as a code owner January 10, 2025 10:39
Irma12
Irma12 previously approved these changes Jan 10, 2025
'@roadiehq/backstage-plugin-github-insights': major
---

BREAKING: Needs SCM auth API to be configured in the application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we could either provide a snippet here or give a file reference to where this is done in our app (or Backstage)? As much as this is standard now it might help someone.

@Xantier Xantier requested a review from a team January 10, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants