Switch to pull_request_target
#13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event `pull_request_target` is now used to trigger this workflow, instead of `pull_request`. This ensures the workflow can run properly on forks (related: Roblox#6). You can read more about this new event here: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
Gudahtt
commented
Aug 25, 2020
| @@ -9,7 +9,7 @@ export class PullCheckRunner { | |||
| } | |||
|
|
|||
| public async rerunLastCheck() { | |||
| if (this.settings.payloadAction === "pull_request") { | |||
| if (this.settings.payloadAction === "pull_request_target") { | |||
There was a problem hiding this comment.
This seems like a breaking change 🤔 Though maybe that's OK.
Alternatively, we could handle both events as a possible trigger.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event
pull_request_targetis now used to trigger this workflow, instead ofpull_request. This ensures the workflow can run properly on forks (related: #6).You can read more about this new event here: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/