Handle PRs with over 100 comments #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
support-PRs-with-over-100-comments
branch
from
d1040d4 to
fbb317a
Compare
When trying to find an existing comment or look for a signature, the bot only looks at the first 100 comments of the PR. This is because 100 is the default page size for PR comments returned by the GitHub API. As a result, if many comments are made before the bot comment, it will keep re-posting it. Additionally, if many comments are made before the signature itself, the bot will never find it. Both attempts to find comments have been updated to continue asking for pages until all comments have been reviewed.
Gudahtt
force-pushed
the
support-PRs-with-over-100-comments
branch
from
fbb317a to
9898a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to find an existing comment or look for a signature, the bot only looks at the first 100 comments of the PR. This is because 100 is the default page size for PR comments returned by the GitHub API. As a result, if many comments are made before the bot comment, it will keep re-posting it. Additionally, if many comments are made before the signature itself, the bot will never find it.
Both attempts to find comments have been updated to continue asking for pages until all comments have been reviewed.