Skip to content

Releases: Roblox/cla-signature-bot

v2.1.0: Update dependencies and action structure

30 Nov 21:42
6345ea8
Compare
Choose a tag to compare

What's Changed

  • EECI 6093: Use Vercel NCC and dist flow instead of lib by @rgychiu in #51
  • EECI 6094: rename and add build and test workflow by @rgychiu in #52
  • EECI 6095: Update dependencies by @rgychiu in #53
  • fix: Run test in PRs by @rgychiu in #54

Full Changelog: v2...v2.1.0

v2.0.2: Fix user mentions

06 Jan 22:32
6285408
Compare
Choose a tag to compare

Fixes an issue where the CLA bot would mention display names if an account can't be found and lead to other accounts that aren't involved getting pinged. Accounts that aren't found and haven't signed the CLA will now only show display names without a prepended @.

v2.0.1: Fix issues with fork-based PRs

12 Jun 06:47
b8cbfb2
Compare
Choose a tag to compare

This resolves #6 and a related issue wherein the token provided for fork-based PRs are read-only when running in the context of the fork. Secrets are also not forwarded into pull_request event handling workflows.

To get around this issue the Action will only attempt to comment when running in a non-PR context, otherwise you'll get a warning. This allows the action to proceed from a PR if everyone has signed the repo.

There is one catch: Someone needs to comment in the PR directly for it to show the CLA comment. It can be anyone or anything, but it needs to come from some source other than the PR.

If GitHub eventually allows more fine-grained controls then this catch may be able to be resolved. In the meantime, this Action will assume that you have a conversation in your PRs that come in from forks 🙂

v2.0.1-beta2

12 Jun 06:34
b8cbfb2
Compare
Choose a tag to compare
v2.0.1-beta2 Pre-release
Pre-release

Additional fixes for fork-based PRs.

v2.0.1: Fix missing PAT from fork-based PRs

12 Jun 02:24
1ad667d
Compare
Choose a tag to compare

This resolves #6 by gracefully failing when a fork's pull request run doesn't have the remote repo PAT secret. Since it's only reading the CLA signature list and not writing to it this shouldn't be an issue.

2.0.0: Roblox Rewrite Release

10 Jun 02:39
Compare
Choose a tag to compare

This represents the first release of the Roblox-initiated rewrite of this action. The original action authors are thoroughly thanked for their efforts, the groundwork of that project lead to the development of this release.

The primary new feature of this release is remote repo support. By using a remote repository signatures can be stored in a common fashion across multiple open-source repositories rather than individually for each separate repository. This prevents developers from having to agree to the same CLA multiple times when submitting work to repositories owned by the same company.

Additionally, this release adds support for automatic re-running of blocking PR checks. When a signature was made the original action would add an empty commit to the PR. This re-ran the blocking checks and made the PR mergable. It has the downside of re-running all other checks as well as not working on forks. Instead this release attempts to re-run the latest available PR-blocking workflow run so that it will pass. There is currently a GitHub API bug that is making this unreliable though, and the comment will indicate as such. Manually re-running will make it pass.