Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing groceries changes #935

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Storing groceries changes #935

merged 2 commits into from
Jan 14, 2025

Conversation

LeroyR
Copy link
Member

@LeroyR LeroyR commented Jan 6, 2025

Description

Storing Groceries changes to move the league forward. We want robots to start using the door handles and pick items directly from the shopping bag.
Also this incorporates pouring from the removed serving breakfast task by refilling a dry storage container.

  • Increase time limit to 7 minutes.
  • Opening door is now a main goal.
    • Additionally we close both doors to have a more realistic scenario.
  • Remove the team dependent setup (request door open, objects) instead the robot should just handle the situation.
    • Select the non heavy object if grasping is impossible for the robot
    • Requesting assistance for door opening
  • Incorporate pouring by refilling a dry storage container with cornflakes.
    • Container is placed on the table for now.
  • Grasping objects from a shopping bag
    • placed next to table.

@LeroyR
Copy link
Member Author

LeroyR commented Jan 6, 2025

Reopen from 79cfe5a as chktex was stuck

@ARTenshi
Copy link
Collaborator

ARTenshi commented Jan 9, 2025

Opening door is now a main goal.

Is it? It might be too hard to include this "Additionally we close both doors to have a more realistic scenario" and making it mandatory at the same time.

@LeroyR
Copy link
Member Author

LeroyR commented Jan 9, 2025

Opening door is now a main goal.

Is it? It might be too hard to include this "Additionally we close both doors to have a more realistic scenario" and making it mandatory at the same time.

We can keep it optional but i would still keep all doors closed.

Rather than the team telling the referee, the robot can just state that it could not open the doors and ask for help (like teams did for the chairs at the table during the last world cup)

Optional goals only enforce teams to solve a part of the main task first before attempting the optionals. But opening the door is the first action in the task anyway. Do we want to give 0 point for a team just opening the door but failing to grasp an item afterwards. We could say that the robot did nothing to solve the main part of storing groceries but then give 15 points for reaching the location?

tldr; I rather remove all "ask teams how to setup the arena" and then being an optional goal does not make much sense imho.

@SparkRibeiro21
Copy link
Contributor

I agree with what it is right now: We put it as a main goal and just add the DEM. This way the doors always start closed and robots can ask for help.

SparkRibeiro21
SparkRibeiro21 previously approved these changes Jan 11, 2025
akinobu1998
akinobu1998 previously approved these changes Jan 13, 2025
ARTenshi
ARTenshi previously approved these changes Jan 13, 2025
Copy link
Collaborator

@ARTenshi ARTenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@LeroyR LeroyR dismissed stale reviews from ARTenshi, akinobu1998, and SparkRibeiro21 via 05749ca January 14, 2025 09:43
@LeroyR LeroyR merged commit 4411699 into master Jan 14, 2025
8 checks passed
@LeroyR LeroyR deleted the improved_sg branch January 14, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants