new interface #44
Open
new interface #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daw1012345
reviewed
Apr 21, 2021
daw1012345
reviewed
Apr 21, 2021
daw1012345
reviewed
Apr 21, 2021
| @@ -30,7 +30,7 @@ message TextField { | |||
| string text = 1; | |||
| } | |||
|
|
|||
| message UiOption { | |||
| message UiOptionDeclaration { | |||
There was a problem hiding this comment.
Looks good, the one thing I'm unsure about is how we'll toggle the mutability of a field. Should this be a boolean here?
There was a problem hiding this comment.
Good one, I'll add it. Worst case we don't end up using/needing it.
There was a problem hiding this comment.
I also forgot to mention field descriptions we discussed - it appears those are missing as well.
|
Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.