This repository has been archived by the owner on Jun 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Version 1.0.1 #65
Open
interstateone
wants to merge
62
commits into
master
Choose a base branch
from
1.0.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Version 1.0.1 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Begins the separation of recording management and the dropbox syncing (JEFSyncingService)
JEFRecordingsController acts as a facade for both a repository and syncing service. This allows a single internal API that can be used for view controllers. Added a recordings provider protocol for cases where only read access is required.
Refactor recording management
Turns out that if you create the gif without optimizations and with constant frame delay once, and then run it through again to optimize, it'll do what you expect.
Improve GIF quality by running them through gifsicle twice
Use timestamps for filenames instead of UUIDs
Add filesystem filters so only valid GIF files are loaded
Check for nil before adding Dropbox public URL to array of share items
The warning is incorrect, but the code makes it difficult for the compiler to figure that out.
Update project and some dependencies for 10.11 SDK/Xcode 7
Debug and Beta Release use Dev ID * signing Release uses 3rd Party Distribution * (the App Store kind) Sets Jeff and JeffLauncher projects to RandP team
Allow user to cancel uploads before they finish
Conflicts: JeffLauncher/JeffLauncher.xcodeproj/project.pbxproj master didn't have a code sign identity in JeffLauncher that 1.0.1 did, so 1.0.1 was accepted.
Fixes an issue that would cause a crash when deleting a recording that wasn't being uploaded at the moment.
Don't remove recording upload progress observer when not observing
interstateone
force-pushed
the
1.0.1
branch
from
September 26, 2017 21:18
c6cbce5
to
23c53fa
Compare
interstateone
force-pushed
the
master
branch
from
September 26, 2017 21:19
391734b
to
bf5dc15
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.