This repository has been archived by the owner on Sep 17, 2019. It is now read-only.
[20Q Game] Fix Offline Startup Crash #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How this works:
|
Aevyz
commented
Aug 14, 2018
| @@ -43,18 +44,39 @@ | |||
| private boolean guessesAvailable = false; | |||
| private boolean gameFinished = false; | |||
| private boolean stopGame = false; | |||
| private boolean network = false; | |||
There was a problem hiding this comment.
Give this a better name
| startAW(); | ||
| } | ||
|
|
||
| private void startAW(){ |
There was a problem hiding this comment.
This definitely needs changing. Name needs to be changed, way the logic works needs to be changed.
| private void startAW(){ | ||
| startAW(false); | ||
| } | ||
| private void startAW(boolean force){ |
| @@ -83,6 +105,11 @@ public Output react(Interpretation input) { | |||
| String intent = getIntent (input); | |||
| Linguistics.UtteranceSentiment inputSentiment = getInference().inferSentiment(input); | |||
|
|
|||
| if(!network){ | |||
There was a problem hiding this comment.
Alter this, there's probably a cleaner way to do this
|
|
||
| startAW(); | ||
| if(!network){ | ||
| return Output.say("A network connection is required to play this game, should I try and look for a connection again?"); |
| @@ -253,7 +280,7 @@ private Output processUserGuessAnswer(String intent){ | |||
|
|
|||
| private void resetGame(){ | |||
|
|
|||
| aw = new AkiwrapperBuilder().setFilterProfanity(true).build(); | |||
| startAW(true); | |||
There was a problem hiding this comment.
Is this really what you want to do, is it even required that we reset AW. Can you get to this state without AW being set
|
Will completely refactor everything regarding to GameStates soon, which would make this obselete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the code that I used to temp fix this. @ninalovegood please read over this code and correct it to your standards, since many of the solutions here are very "hacky" and probably not suitable for the
develbranch.