fix: should fix the failing api tests

RocketChat · Jan 9, 2025 · 9b8785e · 9b8785e
1 parent b1d17d2
commit 9b8785e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/apps/meteor/server/methods/saveUserProfile.ts b/apps/meteor/server/methods/saveUserProfile.ts
@@ -79,8 +79,8 @@ async function saveUserProfile(
 		await setUserStatusMethod(this.userId, settings.statusType as UserStatus, undefined);
 	}
 
-	if (user && settings.bio !== undefined && settings.bio !== null) {
-		if (typeof settings.bio !== 'string') {
+	if (user && settings.bio !== undefined) {
+		if (settings.bio === null || typeof settings.bio !== 'string') {
 			throw new Meteor.Error('error-invalid-field', 'bio', {
 				method: 'saveUserProfile',
 			});

diff --git a/apps/meteor/tests/end-to-end/api/users.ts b/apps/meteor/tests/end-to-end/api/users.ts
@@ -4571,7 +4571,7 @@ describe('[Users]', () => {
 			.expect(400)
 			.expect((res) => {
 				expect(res.body).to.have.property('success', false);
-				expect(res.body.error).to.include('invalid bio');
+				expect(res.body.error).to.include('bio must be a string');
 			})
 			.end(done);
 	});

diff --git a/yarn.lock b/yarn.lock
@@ -9312,6 +9312,7 @@ __metadata:
     adm-zip: "npm:0.5.16"
     ajv: "npm:^8.17.1"
     ajv-formats: "npm:~3.0.1"
+    ansi-colors: "npm:^4.1.3"
     apn: "npm:2.2.0"
     archiver: "npm:^7.0.1"
     asterisk-manager: "npm:^0.2.0"