Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search functionality in Importer page #31004

Closed
wants to merge 19 commits into from

Conversation

felipe-rod123
Copy link
Contributor

@felipe-rod123 felipe-rod123 commented Nov 17, 2023

Proposed changes (including videos or screenshots)

Currently, the importer page lacks a search functionality, making it difficult for users to locate specific users, channels, or messages to be imported.
If the owner wants to search for a specific user or channel, it doesn’t have a easy way to do it, he will have to manually search in the list.

image

image

Issue(s)

WM-121

Steps to test or reproduce

Admin > Workspace > Import > Import New File > Import

Further comments

Branch from: chore: Message count is not changing after removing channel selection #30799

Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: 4e52a23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #31004 (4e52a23) into develop (157f8f4) will increase coverage by 1.07%.
The diff coverage is 65.90%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31004      +/-   ##
===========================================
+ Coverage    56.72%   57.79%   +1.07%     
===========================================
  Files          883     1754     +871     
  Lines        19990    33648   +13658     
  Branches      3689     6878    +3189     
===========================================
+ Hits         11340    19448    +8108     
- Misses        7956    12686    +4730     
- Partials       694     1514     +820     
Flag Coverage Δ
e2e 51.00% <65.90%> (+8.61%) ⬆️
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@felipe-rod123 felipe-rod123 marked this pull request as ready for review November 22, 2023 17:24
@felipe-rod123 felipe-rod123 requested review from a team as code owners November 22, 2023 17:24
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this branch was created with the base chore/fix-importer-messages-count instead of develop , change this, please, otherwise the chore/fix-importer-messages-count branch is going to be merged with that

@hugocostadev hugocostadev changed the title chore: search functionality in Importer page fix: search functionality in Importer page Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants